-
Notifications
You must be signed in to change notification settings - Fork 6
changed field styles #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed field styles #136
Conversation
|
A preview of b493266 is uploaded and can be seen here: ✨ https://mevislab.github.io/examples/pull/136/ ✨ Changes may take a few minutes to propagate. Since this is a preview of production, content with |
okonrad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should think and discuss about it again.
On the one hand, we should not style everything, on the other hand, we should make it clear if we mean a field, a value, code, or an attribute. For the reader and for future writers.
For fields, we have a <field>fieldName</field>. Maybe rename it to <fieldName>fieldName</fieldName> to make it clearer.
Values do not have to be styled, but it would be nice to easily see them. Maybe just use a monospaced font without any color change. Maybe we can use <fieldValue>fieldValue</fieldValue> or something similar.
Code should be styled as code, like code in here (monospaced font with a background). Examples for code are internalName = FooBar and expandX = Yes.
Attributes are similar to code and could be styled similar - if at all. Examples for attributes are MinDistance (in a vessel skeleton) and type (in an MDL declaration of a new field).
No description provided.